Ticket #10 (defect)

Reminder: I am build UPCIO with HP UPC and with async disabled.

There are a few instances where a pointer to struct is declared with a const target but then either assigned to a pointer with a non-const target or, equivalently, passed as an argument to a function where a pointer with a nonconst target is expected. One example:

upc_all_fread_list_shared takes as its fifth parameter a pointer to const struct. It passes that pointer as fourth argument to gupc_map_vec, which is supposed to be a pointer to nonconst struct. The function gupc_map_vec actually modifies the pointed-to object, so the argument cannot be a pointer to const. If upc_all_fread_list_shared is promising not to modify the pointed to object, it is violating that promise in this call.

A similar problem occurs in the corresponding write function, and in the async variants.

There were some other references to the memvec field in the struct aio_request; it's declared as pointing a upc_shared_memvec, but in upc_all_fread_list_shared_async.upc and possibly elsewhere it is assigned a value from a pointer to const upc_shared_memvec ("casting away the const"). I changed the field definition to include const, and that issue was resolved, but that may not be what is intended.

Some of these discrepancies will be caught by providing prototypes for all the gupc_* functions.